-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] report comments and OWFile reporting filename #1956
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1956 +/- ##
===========================================
+ Coverage 69.93% 89.52% +19.58%
===========================================
Files 315 91 -224
Lines 53979 9200 -44779
===========================================
- Hits 37752 8236 -29516
+ Misses 16227 964 -15263 Continue to review full report at Codecov.
|
All looks good except for one thing. When I create a report, write some comments and save the report, the final comment isn't saved. |
Need more reproductions steps. Can't seem to replicate. The comment saves, or, if unsaved, asks to be. |
I loaded iris.tab, reported File, reported Distributions, reported Box Plot. Wrote comments in each section and saved the report. Comments in File and Distributions were there upon opening html, while the comment for Box Plot disappeared. I tested this three times, once also with only two reported widgets and it's the same - the final comment is missing. We can check tomorrow. |
3e40ebf
to
12f75ca
Compare
I can reproduce the issue on WebEngine. |
47069c7
to
c0a7791
Compare
In HTML5, <textarea> innerHTML no longer syncs with textarea value automatically, hence WebEngine didn't save/export it.
c0a7791
to
1fb1bbe
Compare
@ajdapretnar Please try if this now works. |
Issue
Fixes #1899
Description of changes
Not sure what the problem was re comments. Removing
required=required
in HTML now works for me. in OWFile,self.loaded_file
is now correctly set when the file is loaded, not when browsed for.Includes