Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] report comments and OWFile reporting filename #1956

Merged
merged 2 commits into from
Mar 13, 2017

Conversation

kernc
Copy link
Contributor

@kernc kernc commented Jan 25, 2017

Issue

Fixes #1899

Description of changes

Not sure what the problem was re comments. Removing required=required in HTML now works for me. in OWFile, self.loaded_file is now correctly set when the file is loaded, not when browsed for.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov-io
Copy link

codecov-io commented Jan 25, 2017

Codecov Report

Merging #1956 into master will increase coverage by 19.58%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #1956       +/-   ##
===========================================
+ Coverage   69.93%   89.52%   +19.58%     
===========================================
  Files         315       91      -224     
  Lines       53979     9200    -44779     
===========================================
- Hits        37752     8236    -29516     
+ Misses      16227      964    -15263

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1165800...1fb1bbe. Read the comment docs.

@ajdapretnar
Copy link
Contributor

All looks good except for one thing. When I create a report, write some comments and save the report, the final comment isn't saved.
The rest works great.

@kernc
Copy link
Contributor Author

kernc commented Jan 25, 2017

Need more reproductions steps. Can't seem to replicate. The comment saves, or, if unsaved, asks to be.

@ajdapretnar
Copy link
Contributor

I loaded iris.tab, reported File, reported Distributions, reported Box Plot. Wrote comments in each section and saved the report. Comments in File and Distributions were there upon opening html, while the comment for Box Plot disappeared.

I tested this three times, once also with only two reported widgets and it's the same - the final comment is missing. We can check tomorrow.

@astaric astaric added this to the 3.3.11 milestone Jan 26, 2017
@kernc
Copy link
Contributor Author

kernc commented Jan 27, 2017

I can reproduce the issue on WebEngine.

@astaric astaric modified the milestone: 3.3.11 Jan 30, 2017
@kernc kernc changed the title [FIX] report comments and OWFile reporting filename [WIP] [FIX] report comments and OWFile reporting filename Feb 3, 2017
@astaric astaric modified the milestones: future, 3.3.11 Feb 3, 2017
@kernc kernc force-pushed the fix-report-comments branch 2 times, most recently from 47069c7 to c0a7791 Compare February 6, 2017 15:43
In HTML5, <textarea> innerHTML no longer syncs with textarea value
automatically, hence WebEngine didn't save/export it.
@kernc
Copy link
Contributor Author

kernc commented Mar 8, 2017

@ajdapretnar Please try if this now works.

@kernc kernc changed the title [WIP] [FIX] report comments and OWFile reporting filename [FIX] report comments and OWFile reporting filename Mar 8, 2017
@ajdapretnar ajdapretnar merged commit d26119c into biolab:master Mar 13, 2017
@astaric astaric modified the milestone: future Apr 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants