[FIX] KMeans: Fix crashes when underlying algorithm fails #1974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janezd
changed the title
While fixing the table, improve its layout
janezd
force-pushed
the
fix-kmeans-fail
branch
from
1c3ae96
to
6c0a8d1
Compare
janezd
changed the title
Current coverage is 89.45% (diff: 100%)@@ master #1974 diff @@
==========================================
Files 90 90
Lines 9182 9182
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 8214 8214
Misses 968 968
Partials 0 0
|
astaric
added a commit
that referenced
this pull request
Feb 3, 2017
[FIX] KMeans: Fix crashes when underlying algorithm fails (cherry picked from commit c80741b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
If k-means crashed, so does the widget.
Description of changes
The widget now catches exceptions. If k-means fails only for some k's, it still shows the table but disables the corresponding rows. If all fail (or optimization is disabled), it reports an error.
While fixing the table, I also changed the scaling for silhouette, so the the bars are not normalized according to minimal and maximal observed score but between 0 and 1.
Includes