Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Handle KeyError Sieve Diagram widget (owsieve) when one row #2007

Merged
merged 1 commit into from
Feb 13, 2017
Merged

[FIX] Handle KeyError Sieve Diagram widget (owsieve) when one row #2007

merged 1 commit into from
Feb 13, 2017

Conversation

jerneju
Copy link
Contributor

@jerneju jerneju commented Feb 10, 2017

… selected

Issue

KeyError thrown when only one row selected in data table.

Description of changes

KeyError fix - Handle the error and show the message on top of the widget.

Includes
  • Code changes
  • Tests
  • Documentation

@jerneju
Copy link
Contributor Author

jerneju commented Feb 10, 2017

@jerneju
Copy link
Contributor Author

jerneju commented Feb 10, 2017

@codecov-io
Copy link

codecov-io commented Feb 13, 2017

Codecov Report

Merging #2007 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2007   +/-   ##
=======================================
  Coverage   89.54%   89.54%           
=======================================
  Files          91       91           
  Lines        9213     9213           
=======================================
  Hits         8250     8250           
  Misses        963      963

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a2aa5f...651b017. Read the comment docs.

Issue
KeyError thrown.

Description
Discretizer parameter remove_const set to False. Add test case.
@astaric astaric merged commit b1fbf0a into biolab:master Feb 13, 2017
@astaric
Copy link
Member

astaric commented Feb 13, 2017

@astaric astaric added this to the 3.3.12 milestone Feb 13, 2017
astaric added a commit to astaric/orange3 that referenced this pull request Feb 14, 2017
[FIX] Handle KeyError Sieve Diagram widget (owsieve) when one row
(cherry picked from commit b1fbf0a)
@jerneju jerneju deleted the keyerror-owsieve branch April 20, 2017 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants