[FIX] SelectRows: Fix loading of conditions #2065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astaric
force-pushed
the
select-rows-load-settings
branch
from
6546931
to
d676ee7
Compare
Codecov Report
@@ Coverage Diff @@
## master #2065 +/- ##
==========================================
- Coverage 70.7% 68.64% -2.06%
==========================================
Files 315 315
Lines 53903 53923 +20
==========================================
- Hits 38111 37015 -1096
- Misses 15792 16908 +1116Continue to review full report at Codecov.
|
astaric
force-pushed
the
select-rows-load-settings
branch
from
d676ee7
to
1283ce2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Conditions in select rows are not loaded properly when reading from file (gh-2062)
Description of changes
Make sure the correct ordering of variables is used when restoring conditions.
Includes