[FIX] stats: Open Corpus in OWDataTable after transposing it #2177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2177 +/- ##
=======================================
Coverage 71.55% 71.55%
=======================================
Files 318 318
Lines 54475 54475
=======================================
Hits 38979 38979
Misses 15496 15496Continue to review full report at Codecov.
|
janezd
reviewed
Mar 31, 2017
| @@ -193,24 +193,23 @@ def stats(X, weights=None, compute_variance=False): | |||
| is_sparse = sp.issparse(X) | |||
| weighted = weights is not None and X.dtype != object | |||
|
|
|||
| if weighted: | |||
| weights = np.c_[weights] / sum(weights) | |||
There was a problem hiding this comment.
I'd still compute weights instead of doing it in two places later. Just a suggestion, feel free to ignore.
lanzagar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes: #2156
Description of changes
Includes