[FIX] Test & Score: crashing prevented when learner disconnects #2194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2194 +/- ##
==========================================
+ Coverage 72.02% 72.02% +<.01%
==========================================
Files 318 318
Lines 54580 54583 +3
==========================================
+ Hits 39309 39312 +3
Misses 15271 15271Continue to review full report at Codecov.
|
astaric
reviewed
Apr 6, 2017
| @@ -381,6 +381,29 @@ def shuffle_split_changed(self): | |||
| def _param_changed(self): | |||
| self._invalidate() | |||
|
|
|||
| def push_results(self, learners, results, class_var): | |||
There was a problem hiding this comment.
I would put this method below _update_results and pick another name. A docstring might be a good idea as well, as it is not that obvious what the method does.
lanzagar
requested changes
Apr 7, 2017
| def fill_results(self, learners, results, class_var): | ||
| """ | ||
| Called by _update_results. This method prepares calculated results and | ||
| put them into self.learners. |
When Test & Score performs evaluation sb might disconnect connection from some learner. https://sentry.io/biolab/orange3/issues/227231658/
lanzagar
approved these changes
Apr 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When Test & Score performs evaluation sb might disconnect connection from some learner. Widget then crashes.
https://sentry.io/biolab/orange3/issues/227231658/
Description of changes
Includes