[FIX] Test & Score: Instantly recognize new input #2247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2247 +/- ##
=======================================
Coverage 72.37% 72.37%
=======================================
Files 319 319
Lines 55014 55014
=======================================
Hits 39819 39819
Misses 15195 15195 |
lanzagar
reviewed
Apr 21, 2017
|
|
||
| if self.test_data is not None and \ | ||
| self.resampling != OWTestLearners.TestOnTest: | ||
| self.Warning.test_data_unused() | ||
|
|
||
| if len(items) == 0: |
There was a problem hiding this comment.
Instead of moving the check on items away from its creation, how about moving the check for TestOnTest up, together with other similar checks. The ifs can even be merged.
Otherwise this seems to fix the problem :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#1842
#2219
Description of changes
Includes