preprocess.score.Scorer: Improve error messages #2266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janezd
commented
Apr 28, 2017
| @@ -30,12 +31,37 @@ class Scorer(_RefuseDataInConstructor, Reprable): | |||
| RemoveNaNClasses() | |||
| ] | |||
|
|
|||
| @property | |||
There was a problem hiding this comment.
Sadly, Python doesn't provide @classproperty (and, no, you can't combine @classmethod and @property). Implementing it doesn't make sense for just a few (overpedantic) cases. :)
|
As the old errors were cryptic (to programmers and users), this is a welcome improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
As we discussed in #2205, features selection in the Preprocess widget shows ugly error messages. This happens since it shows exceptions raised by
preprocess.score.Scorer, which are, in turn, in need of improvement.Description of changes
This PR makes the exceptions issued by
preprocess.score.Scorerpresentable.I think we should not do this in general since exceptions are for programmers and error messages in the widgets are for the end-user, so the former have to be exact and technical, including the type names etc, while the latter favour readability over exactness.
A check in
preproces.fssis removed since it is also done inpreprocess.score.Scorer.Includes
No additional tests are needed.