[FIX] Rank widget supports Scorer inputs #2350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @pavlin-policar |
|
My bad, I was completely unaware of this functionality. The changes you made to the Fitter class make things simpler, so that's a big 👍 from me. As far as I can tell (apart from a grammatical mistake in the docs) everything seems okay. I'm not sure what you could do about the Too many ancestors error pylint spits out though... |
| @@ -14,6 +14,11 @@ Signals | |||
|
|
|||
| An input data set. | |||
|
|
|||
| - **Scorer** (multiple) | |||
|
|
|||
| Models that implements feature scoring interface (linear / logistic | |||
There was a problem hiding this comment.
Models that implement the feature scoring interface
Codecov Report
@@ Coverage Diff @@
## master #2350 +/- ##
==========================================
+ Coverage 73.29% 73.34% +0.05%
==========================================
Files 317 317
Lines 55474 55509 +35
==========================================
+ Hits 40658 40714 +56
+ Misses 14816 14795 -21 |
ajdapretnar
approved these changes
May 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Rank didn't support Scorer (e.g Random Forest) inputs since the introduction of Fitters.
Description of changes
Have Rank support Random Forest as an input Scorer. Also SGD.
Includes