[ENH] OWFeatureConstructor: Add new functions from numpy #2410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lopezco
changed the title
|
Overriding sum with nansum is counterintuitive. In case of an unkown value the sum should be unkown as well. Consider adding nansum and others as separate functions. Please rebase the branch to resolve conflicts and fix the pylint errors reported by Travis CI. |
Codecov Report
@@ Coverage Diff @@
## master #2410 +/- ##
==========================================
- Coverage 75.11% 75.07% -0.04%
==========================================
Files 323 323
Lines 56902 56903 +1
==========================================
- Hits 42743 42722 -21
- Misses 14159 14181 +22 |
thocevar
force-pushed
the
feature-constructor-add-functions
branch
from
b8e4be7
to
46ee693
Compare
|
There was a problem with your rebase. Most likely you rebased on a branch that was not synced with biolab:master and ended up with 100+ commits in the pull request. I'll handle the merge from here on, thank you for your contribution. |
|
wow! sorry @thocevar you're right. I didn't check that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Implements new functions
Description of changes
Includes