Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Ensure visible nodes after openning a workflow. #2490

Merged
merged 2 commits into from
Jul 24, 2017

Conversation

ales-erjavec
Copy link
Contributor

Issue

In case the user opens a workflow whose nodes are very far from coordinate origin there is nothing visible in the viewport.

Example:

<?xml version='1.0' encoding='utf-8'?>
<scheme description="" title="" version="2.0">
	<nodes>
		<node id="0" name="Constant" position="(3779.0, 2765.0)" project_name="Orange3" qualified_name="Orange.widgets.model.owconstant.OWConstant" title="Constant" version="" />
	</nodes>
	<links />
	<annotations />
	<thumbnail />
</scheme>
Description of changes

Scroll the viewport to the first node.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov-io
Copy link

Codecov Report

Merging #2490 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2490      +/-   ##
==========================================
- Coverage   74.52%   74.49%   -0.03%     
==========================================
  Files         321      321              
  Lines       56086    56086              
==========================================
- Hits        41797    41781      -16     
- Misses      14289    14305      +16

@BlazZupan BlazZupan merged commit 2d388d0 into biolab:master Jul 24, 2017
@ales-erjavec ales-erjavec deleted the fixes/canvas-ensure-visible branch November 14, 2017 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants