Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] MDS: similar pairs and combos not cleared #2643

Merged
merged 2 commits into from
Oct 3, 2017
Merged

[FIX] MDS: similar pairs and combos not cleared #2643

merged 2 commits into from
Oct 3, 2017

Conversation

jerneju
Copy link
Contributor

@jerneju jerneju commented Oct 2, 2017

Issue
  1. Combos do not clear when data connection is removed.
  2. Adding or removing subset data clears connections between similar pairs.
Description of changes
Includes
  • Code changes
  • Tests
  • Documentation

@jerneju jerneju changed the title Mds fix pairs and combos [FIX] MDS: fix pairs and combos Oct 2, 2017
@jerneju jerneju changed the title [FIX] MDS: fix pairs and combos [FIX] MDS: similar pairs and combos not cleared Oct 2, 2017
@jerneju jerneju requested a review from lanzagar October 2, 2017 10:25
@codecov-io
Copy link

Codecov Report

Merging #2643 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2643      +/-   ##
==========================================
+ Coverage   75.18%   75.18%   +<.01%     
==========================================
  Files         331      331              
  Lines       57803    57805       +2     
==========================================
+ Hits        43460    43462       +2     
  Misses      14343    14343

@lanzagar lanzagar merged commit 6608df9 into biolab:master Oct 3, 2017
@jerneju jerneju deleted the mds-fix-pairs-and-combos branch October 3, 2017 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants