Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Hierarchical Clustering: Fix size constraints #2796

Conversation

ales-erjavec
Copy link
Contributor

Issue

The dendrogram can be resized below its minimum width (without horizontal scroll bars shown).

Description of changes
  • Set minimum width constraint in the graphics view to ensure scroll bars would not be needed.
  • Improve size hinting.
  • Fix cutoff line/slider updates.
  • Fix dendrogram font scale (zoom) initialization.
Includes
  • Code changes
  • Tests
  • Documentation

@codecov-io
Copy link

codecov-io commented Nov 27, 2017

Codecov Report

Merging #2796 into master will increase coverage by 4.67%.
The diff coverage is 70.37%.

@@            Coverage Diff             @@
##           master    #2796      +/-   ##
==========================================
+ Coverage    76.1%   80.77%   +4.67%     
==========================================
  Files         338      324      -14     
  Lines       59767    56223    -3544     
==========================================
- Hits        45486    45415      -71     
+ Misses      14281    10808    -3473

@lanzagar lanzagar added this to the 3.9 milestone Nov 29, 2017
@ales-erjavec
Copy link
Contributor Author

@janezd Can you please check if it behaves correctly now.

@janezd
Copy link
Contributor

janezd commented Dec 8, 2017

It does. I'll merge when tests are finished.

@janezd janezd merged commit 03ee289 into biolab:master Dec 8, 2017
@ales-erjavec ales-erjavec deleted the fixes/owhierarchicalclustering-size-constraints branch December 12, 2017 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants