[FIX] heatmap: Do not crash on all zero column #2916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2916 +/- ##
=========================================
+ Coverage 82.1% 82.1% +<.01%
=========================================
Files 328 328
Lines 56262 56268 +6
=========================================
+ Hits 46194 46201 +7
+ Misses 10068 10067 -1 |
lanzagar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Heatmap with column clustering crashes when data contains a column an all-zero column.
Column clustering is done using Pearson distance which is nan for a column of all zeros.
Description of changes
Convert non-finite values to finite using np.nan_to_num. This results in zero feature being clustered with a random other feature, but the rest of the clustering should make sense.
Includes