Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] owselectrows: Change defaults for 'Purging' #2969

Merged

Conversation

ales-erjavec
Copy link
Contributor

Issue

By default Select Rows widget should not do more then what is says on the tin.

(references gh-2925)

Description of changes

Change the defaults for purging to False.

Includes
  • Code changes
  • Tests
  • Documentation

@ajdapretnar ajdapretnar self-assigned this Mar 23, 2018
@codecov-io
Copy link

codecov-io commented Mar 23, 2018

Codecov Report

Merging #2969 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2969      +/-   ##
==========================================
- Coverage   81.86%   81.85%   -0.01%     
==========================================
  Files         329      329              
  Lines       56787    56781       -6     
==========================================
- Hits        46488    46480       -8     
- Misses      10299    10301       +2

@ales-erjavec ales-erjavec force-pushed the fixes/select-rows-purge-defaults branch from 1c6f994 to 801c4df Compare March 23, 2018 11:16
@ajdapretnar ajdapretnar merged commit 987a5d8 into biolab:master Mar 23, 2018
@ales-erjavec ales-erjavec deleted the fixes/select-rows-purge-defaults branch March 26, 2018 06:49
@astaric astaric added this to the 3.12 milestone Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants