[FIX] tests: Fix time tracking in process_events #3041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `perf_counter` (wall time) not `clock` (CPU time). `clock` is deprecated and platform dependent, but mostly does not measure time spent in sleep.
Codecov Report
@@ Coverage Diff @@
## master #3041 +/- ##
=======================================
Coverage 82.31% 82.31%
=======================================
Files 335 335
Lines 57758 57758
=======================================
Hits 47541 47541
Misses 10217 10217 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Sometimes tests seemingly deadlock but in reality it they spin (really sleep) in
WidgetTest.process_eventsway past the real timeout (due to improper time keeping).Description of changes
Use
time.perf_counternottime.clock.clockis deprecated and platform dependent, but mostly does not measure timespent in sleep.
Includes