[ENH] MergeData: add autocommit button #3091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #3091 +/- ##
==========================================
+ Coverage 82.42% 82.42% +<.01%
==========================================
Files 335 335
Lines 58037 58045 +8
==========================================
+ Hits 47838 47846 +8
Misses 10199 10199 |
astaric
reviewed
Jun 26, 2018
Orange/widgets/data/owmergedata.py
Outdated
| @@ -246,7 +250,8 @@ def commit(self): | |||
| self.Outputs.data.send(merged_data) | |||
|
|
|||
| def _invalidate(self): | |||
| self.commit() | |||
| if self.auto_apply: | |||
There was a problem hiding this comment.
this should not be necessary. when auto_commit button is added to the widget, it patches commit method so it performs this check.
| @@ -450,3 +450,10 @@ def test_sparse(self): | |||
|
|
|||
| output_sparse.X = output_sparse.X.toarray() | |||
| self.assertTablesEqual(output_dense, output_sparse) | |||
|
|
|||
| def test_disable_auto_apply(self): | |||
There was a problem hiding this comment.
please also check that auto_apply works when enabled
astaric
approved these changes
Jun 28, 2018
astaric
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #2927
Description of changes
Add autocommit button.
Includes