Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] PCA: Rename components to PC1, PC2, PC3, ... #3423

Merged
merged 3 commits into from
Nov 30, 2018

Conversation

VesnaT
Copy link
Contributor

@VesnaT VesnaT commented Nov 28, 2018

Issue

PCA components (for n_components = 2) have been accidentally renamed to PCA-x and PCA-y in one of previous PRs. Rename the components to PC1 and PC2.

Description of changes
Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Nov 28, 2018

Codecov Report

Merging #3423 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3423      +/-   ##
==========================================
- Coverage   82.35%   82.35%   -0.01%     
==========================================
  Files         360      360              
  Lines       64183    64185       +2     
==========================================
+ Hits        52861    52862       +1     
- Misses      11322    11323       +1

@lanzagar lanzagar merged commit 0de1f7b into biolab:master Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants