[FIX] OWFeatureStatistics: Don't attempt to sort when no data on input #3449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavlin-policar
changed the title
Codecov Report
@@ Coverage Diff @@
## master #3449 +/- ##
==========================================
- Coverage 83.27% 83.27% -0.01%
==========================================
Files 365 365
Lines 64305 64305
==========================================
- Hits 53549 53547 -2
- Misses 10756 10758 +2 |
lanzagar
reviewed
Dec 10, 2018
| @@ -807,7 +807,7 @@ def __restore_selection(self): | |||
| def __restore_sorting(self): | |||
| """Restore the sort column and order from saved settings.""" | |||
| sort_column, sort_order = self.sorting | |||
| if sort_column < self.model.columnCount(): | |||
| if self.data is not None and sort_column < self.model.columnCount(): | |||
There was a problem hiding this comment.
So __restore_sorting does nothing if self.data is None. In that case maybe it should be called only when self.data is not None (in the set_data method above)? Is the same true for __restore_selection?
There was a problem hiding this comment.
I thought about putting the None check in set_data, but decided to put it here instead to keep the __restore_* methods consistent. The other methods properly handle the case where there is no data, only this one fails. It seemed cleaner to just make them all work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
An issue popped up on sentry where Feature Statistics was crashing. This can be reproduced in the following way:
Description of changes
Fixes the bug. I have no idea how to test this, or indeed, how this even happened because this issue never occurred when disconnecting data. In both cases, the input signal data was set to
None.Includes