[ENH] t-SNE: Updates 2. #3475
Merged
[ENH] t-SNE: Updates 2. #3475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VesnaT
force-pushed
the
tsne4
branch
3 times, most recently
from
7a5a19a
to
0fc819f
Compare
Codecov Report
@@ Coverage Diff @@
## master #3475 +/- ##
==========================================
+ Coverage 83.49% 83.51% +0.01%
==========================================
Files 367 367
Lines 65282 65300 +18
==========================================
+ Hits 54509 54533 +24
+ Misses 10773 10767 -6 |
Codecov Report
@@ Coverage Diff @@
## master #3475 +/- ##
==========================================
+ Coverage 83.55% 83.58% +0.02%
==========================================
Files 367 367
Lines 65454 65476 +22
==========================================
+ Hits 54690 54725 +35
+ Misses 10764 10751 -13 |
| @@ -82,7 +80,7 @@ class OWtSNE(OWDataProjectionWidget): | |||
| embedding_variables_names = ("t-SNE-x", "t-SNE-y") | |||
|
|
|||
| #: Runtime state | |||
| Running, Finished, Waiting = 1, 2, 3 | |||
| Running, Finished, Waiting, Pending = 1, 2, 3, 4 | |||
There was a problem hiding this comment.
Maybe "Pending" isn't the greatest name for what this indicates. A better name would be "Paused". Which kind of begs the question of what "Waiting" means...
|
@janezd This PR should be merged, but I don't have permissions to merge unless all the checks pass. Could you please use your superpower and press merge? |
|
Sure. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description of changes
Includes