Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Orange restart dialogs: Improve wording #3605

Merged
merged 3 commits into from
Feb 18, 2019
Merged

Conversation

JakaKokosar
Copy link
Member

@JakaKokosar JakaKokosar commented Feb 15, 2019

Issue

Fixes #2581

Description of changes

Reset widget settings:
clear_settings

Also for add-on manager:
add-ons

Includes
  • Code changes
  • Tests
  • Documentation

@lanzagar
Copy link
Contributor

Maybe:
A restart of the application is necessary -> Orange needs to be restarted
?

We are also somewhat misleading here by letting the user select "restart" and then stare at the computer when orange closes and does not start again :)
But I am fine with this if it is hard to actually restart the application (we would need to close the current one to save settings etc, before starting a new instance).

Also, note that pylint is complaining - it seems you removed a call to a function that is now imported, but never used.

@codecov
Copy link

codecov bot commented Feb 15, 2019

Codecov Report

Merging #3605 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3605      +/-   ##
==========================================
- Coverage   84.02%   84.01%   -0.01%     
==========================================
  Files         370      370              
  Lines       67232    67232              
==========================================
- Hits        56490    56486       -4     
- Misses      10742    10746       +4

@JakaKokosar
Copy link
Member Author

@lanzagar, is this clearer?

Reset widget settings: "Close Orange or cancel operation"
screenshot 2019-02-15 at 15 20 28

add-on manager: "Close Orange or do it later (operation was already performed)"
screenshot 2019-02-15 at 15 20 10

@lanzagar
Copy link
Contributor

I think the second part of the message was good before ("for the changes to take effect") since it indicates what will happen if the user clicks Cancel (-> then changes will not take effect).
I would also add "now" at the end of "press ok to close orange"

In summary, the whole message should be:

Orange needs to be restarted for the changes to take effect.
Press OK to close Orange now.

@lanzagar lanzagar changed the title [RFC] Orange restart dialogs [FIX] Orange restart dialogs: Improve wording Feb 18, 2019
@lanzagar lanzagar merged commit 24dee7b into biolab:master Feb 18, 2019
@JakaKokosar JakaKokosar deleted the dev branch April 3, 2020 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants