[FIX] Orange: add more informatino on missing compiled libraries #3614
Conversation
Orange/__init__.py
Outdated
| from Orange.data import _variable | ||
| except ImportError: | ||
| raise ImportError("Compiled libraries cannot be found.\n" | ||
| "Try reinstalling the package with: pip install --no-binary Orange3") from None |
There was a problem hiding this comment.
Break this line and then I'm merging. :)
Since you'll modify the commit anyway, do you think it would make sense to import other modules, too? It's probably possible that _variable would exist, but some other module would fail to compile.
In the future, we probably won't remember to add new modules here when we introduce them, but it's still better to have at least those that exist now.
This is just a thought. If you disagree, just break the line and we're done. :)
There was a problem hiding this comment.
I added the brake.
If the compile fails pip shows errors. I think the import problems lies somewhere else.
I would therefore argue that either all library work or none does so there is no point in adding all the imports.
There was a problem hiding this comment.
I meant breaking the line because of pylint, not to add a \n to the message, too. But this is OK as well.
robertcv
force-pushed
the
fix/compiled_libraries
branch
from
02eb4ab
to
7727809
Compare
Codecov Report
@@ Coverage Diff @@
## master #3614 +/- ##
==========================================
+ Coverage 84.07% 84.07% +<.01%
==========================================
Files 370 370
Lines 67256 67252 -4
==========================================
- Hits 56544 56542 -2
+ Misses 10712 10710 -2 |
Codecov Report
@@ Coverage Diff @@
## master #3614 +/- ##
==========================================
+ Coverage 84.07% 84.07% +<.01%
==========================================
Files 370 370
Lines 67256 67256
==========================================
+ Hits 56544 56545 +1
+ Misses 10712 10711 -1 |
Issue
Fixes #3482
There is unfortunately no straightforward way to add post install for wheels (pypi/packaging-problems#64)
Description of changes
Add additional information if import of compiled libraries failes.
Includes