Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Transform: Replace 'Preprocess' input with 'Template Data' input #3673

Merged
merged 4 commits into from
Mar 15, 2019

Conversation

VesnaT
Copy link
Contributor

@VesnaT VesnaT commented Mar 13, 2019

Issue

Fixes #3623 and #3675.

Description of changes
  • remove 'Preprocessor' output from projection widgets (PCA, tSNE, Freeviz, Radviz, LinearProjection)
  • OWTransform: use domain to transform data (instead of preprocessor)
Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Mar 13, 2019

Codecov Report

Merging #3673 into master will decrease coverage by <.01%.
The diff coverage is 98.01%.

@@            Coverage Diff             @@
##           master    #3673      +/-   ##
==========================================
- Coverage   84.35%   84.34%   -0.01%     
==========================================
  Files         370      370              
  Lines       67954    67903      -51     
==========================================
- Hits        57321    57272      -49     
+ Misses      10633    10631       -2

@VesnaT VesnaT changed the title [FIX] Transform: Replace 'Preprocess' input with 'Template Data' input [WIP][FIX] Transform: Replace 'Preprocess' input with 'Template Data' input Mar 13, 2019
Orange/widgets/unsupervised/tests/test_owpca.py Outdated Show resolved Hide resolved
Orange/widgets/data/owtransform.py Outdated Show resolved Hide resolved
Orange/widgets/data/owtransform.py Outdated Show resolved Hide resolved
@VesnaT
Copy link
Contributor Author

VesnaT commented Mar 14, 2019

Since OWTransform now makes transformation using arbitrary domain, we should probably reconsider #3526.

@VesnaT VesnaT force-pushed the transform_enh branch 2 times, most recently from 0b42e84 to 2680ac4 Compare March 14, 2019 08:59
@janezd
Copy link
Contributor

janezd commented Mar 14, 2019

Is this still WIP?

What about renaming the widget - do we have a better name?

I agree we should reconsider #3526.

@VesnaT
Copy link
Contributor Author

VesnaT commented Mar 14, 2019

It's WIP because of #3526.
I don't know about the name. I wouldn't change it until we completely agree on the new one.
Besides, any ideas on what to do with the (removed/replaced) signals to make saved workflows work?

@janezd
Copy link
Contributor

janezd commented Mar 14, 2019

#3526 can be dealt with later.

Name: let's find one tomorrow.

What about not caring about saved workflows in this case? The widget was not around for long so it couldn't had been used extensively, while supporting this, even if perhaps possible (though not entirely clear how), would include too much dead code.

@VesnaT VesnaT changed the title [WIP][FIX] Transform: Replace 'Preprocess' input with 'Template Data' input [FIX] Transform: Replace 'Preprocess' input with 'Template Data' input Mar 14, 2019
@janezd janezd merged commit b5d6f5a into biolab:master Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants