[ENH] Replace popups with non-intrusive notifications #3855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irgolic
force-pushed
the
popups-to-non-intrusive-notifications
branch
4 times, most recently
from
74be9ca
to
7596426
Compare
Codecov Report
@@ Coverage Diff @@
## master #3855 +/- ##
==========================================
+ Coverage 84.28% 84.97% +0.68%
==========================================
Files 384 378 -6
Lines 72736 70496 -2240
==========================================
- Hits 61307 59905 -1402
+ Misses 11429 10591 -838 |
irgolic
force-pushed
the
popups-to-non-intrusive-notifications
branch
7 times, most recently
from
6f7b171
to
e323faa
Compare
irgolic
changed the title
irgolic
force-pushed
the
popups-to-non-intrusive-notifications
branch
4 times, most recently
from
cc8145a
to
7124a97
Compare
Orange/canvas/__main__.py
Outdated
| def handle_response(result): | ||
| if result == QMessageBox.Yes: | ||
| surveyDialogButtons = NotificationWidget.Ok | NotificationWidget.Close | ||
| surveyDialog = NotificationWidget(icon=QIcon("Orange/widgets/icons/information.png"), |
There was a problem hiding this comment.
These icon paths must be absolute. They will not be located unless running at top level installation directory.
There was a problem hiding this comment.
I used Orange.widgets.gui.resource_filename() in place of absolute paths. Consider this temporary until we receive custom made icons, which will be placed in Orange/canvas/icons, retrieved with canvas_icons().
irgolic
force-pushed
the
popups-to-non-intrusive-notifications
branch
from
7124a97
to
b344240
Compare
irgolic
force-pushed
the
popups-to-non-intrusive-notifications
branch
from
b344240
to
2b216b4
Compare
ales-erjavec
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The first of (likely) three pull requests implementing #3372
Description of changes
Implements notifications in the bottom right-hand corner of the canvas, allowing a user to accept, reject or dismiss the notification at their own leisure, as opposed to being interrupted by a pop-up pausing the program.
Includes