[ENH] BoxPlot: Write the anova/t-test statistic onto the plot. #3945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajdapretnar
reviewed
Jul 26, 2019
Codecov Report
@@ Coverage Diff @@
## master #3945 +/- ##
==========================================
- Coverage 85.02% 85.02% -0.01%
==========================================
Files 378 378
Lines 66705 66688 -17
==========================================
- Hits 56715 56700 -15
+ Misses 9990 9988 -2 |
Codecov Report
@@ Coverage Diff @@
## master #3945 +/- ##
=========================================
+ Coverage 85.02% 85.13% +0.1%
=========================================
Files 378 378
Lines 66705 67124 +419
=========================================
+ Hits 56715 57144 +429
+ Misses 9990 9980 -10 |
janezd
reviewed
Jul 31, 2019
| def draw_stat(self): | ||
| if self.stat_test: | ||
| l = QGraphicsSimpleTextItem(self.stat_test) | ||
| l.setFont(self._axis_font) |
There was a problem hiding this comment.
The text does not render correctly on my machine -- small parentheses, and no ' in "Student's".
It works (and also looks OK) if I remove setFont.
There was a problem hiding this comment.
Our _axis_font, which is just the default (_axis_font = QFont()), doesn't display some characters nicely? This is bad.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #3927
Description of changes
Move the t-test or anova statistic from the widget onto the plot, which puts it in the report and on the exported image.
Includes