[ENH] Datasets: Remove control area

[janezd]

Sapientem sat?

(Fixes #4069.)

To show indicators with different colors, it needs biolab/orange-widget-base#17. Before biolab/orange-widget-base#17 is merged, indicators will remain black, as they are now, but the widget will still work.

Includes

• Code changes

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@e378407). Click here to learn what that means.
The diff coverage is 78.57%.

@@            Coverage Diff            @@
##             master    #4071   +/-   ##
=========================================
  Coverage          ?   85.56%           
=========================================
  Files             ?      385           
  Lines             ?    69189           
  Branches          ?        0           
=========================================
  Hits              ?    59200           
  Misses            ?     9989           
  Partials          ?        0

[PrimozGodec]

I tested it and it works well. There is just a need to change the documentation screenshots and maybe add a sentence about the status color. Should we do it here or in the separate PR?

[lanzagar]

I like the change.

Some comments:

• Users could previously choose a dataset and click Send (or have auto send checked). After we remove the button, double click is probably the only way to do this? Is that obvious enough (honest question, I don't know)?
  We rarely use double clicking in Orange and there was a more direct way before that now just disappears. Maybe we could (temporarily?) have an info box at the top of the widget like in Test&Score, which would explain "Double click a dataset to load it" or similar?
• Upon downloading a dataset warnings are printed: 'processEvents' argument is deprecated.
  It has nothing to do with this PR, but it should be as simple as searching for and removing all occurrences of processEvents=None.
• This breaks Single Cell Datasets. There should probably be some refactoring and maybe a common base class, but I would avoid dragging all that into this PR. I think the following should be enough:
  • We add openclass=True, just to make it clearer that this widget is reused (it should have been there already)
  • You changed load_data to load_and_output. We could leave load_data as it was and just call it inside a new method, which should then work fine with the downstream changes.

[lanzagar]

The previous load_data method is overriden in Single Cell Datasets.
You can still call it here and make this a new method instead of changing it from load_data, which should keep everything working downstream.

[janezd]

Users could previously choose a dataset and click Send (or have auto send checked). After we remove the button, double click is probably the only way to do this? Is that obvious enough

I suppose. If nothing happens on single click, the normal reflex is to double-click.

Upon downloading a dataset warnings are printed: 'processEvents' argument is deprecated.
It has nothing to do with this PR, but it should be as simple as searching for and removing all occurrences of processEvents=None.

I didn't want to do this in this PR, but it's trivial, so now I did it.

This breaks Single Cell Datasets. There should probably be some refactoring and maybe a common base class, but I would avoid dragging all that into this PR. I think the following should be enough:
We add openclass=True, just to make it clearer that this widget is reused (it should have been there already)
You changed load_data to load_and_output. We could leave load_data as it was and just call it inside a new method, which should then work fine with the downstream changes.

I restored load_data, but I wouldn't add openclass=True. It is preferable to have a warning that reminds us to extract common routines to a base class. openclass=True is also a promise that we won't break compatibility; we can only do this after refactoring.

[PrimozGodec]

Users could previously choose a dataset and click Send (or have auto send checked). After we remove the button, double click is probably the only way to do this? Is that obvious enough (honest question, I don't know)?

What about having a send button/apply at the bottom of the widget (similarly than file widget has)?

[janezd]

Check whether pressing return also submits the data.

Add Tooltip: "Double click to send".

[janezd]

Use a different symbol for active data set. Move the delegate here so we can add different symbols in the future.