Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] owcsvimport: Make the progress update a direct connection #4109

Merged
merged 1 commit into from
Oct 18, 2019

Conversation

ales-erjavec
Copy link
Contributor

Issue

After finishing the widget sometimes still displays the progress.

Description of changes

Make the progress update connection to the widget using a direct
connection to ensure no pending queued updates are received.

Includes
  • Code changes
  • Tests
  • Documentation

Make the progress update connection to the widget using a direct
connection to ensure no pending queued updates.
@codecov
Copy link

codecov bot commented Oct 17, 2019

Codecov Report

Merging #4109 into master will decrease coverage by <.01%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #4109      +/-   ##
==========================================
- Coverage   85.58%   85.58%   -0.01%     
==========================================
  Files         385      385              
  Lines       69228    69232       +4     
==========================================
+ Hits        59249    59251       +2     
- Misses       9979     9981       +2

@janezd janezd merged commit 10965d5 into biolab:master Oct 18, 2019
@ales-erjavec ales-erjavec deleted the owcsvimport-progress-disconnect branch March 16, 2020 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants