[FIX] Feature Statistics: Do not crash on empty domain #4245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janezd
force-pushed
the
featstat-noattrs
branch
from
e9d3f7c
to
27d5ef3
Compare
Codecov Report
@@ Coverage Diff @@
## master #4245 +/- ##
==========================================
+ Coverage 86.05% 86.05% +<.01%
==========================================
Files 394 394
Lines 70227 70230 +3
==========================================
+ Hits 60432 60437 +5
+ Misses 9795 9793 -2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Feature Statistics crashes on data with an empty Domain.
To reproduce: File (iris) -> Select Columns (remove everything) -> Feature Statistics
Description of changes
Sort only if there is something to sort.
Includes