Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Merge Data: Implement context settings #4248

Merged
merged 3 commits into from
Dec 6, 2019

Conversation

janezd
Copy link
Contributor

@janezd janezd commented Dec 5, 2019

Fixes #4210.

Includes
  • Code changes
  • Tests

@janezd janezd force-pushed the mergedata-contexts branch 3 times, most recently from bb77de8 to 4738361 Compare December 5, 2019 17:09
@janezd janezd force-pushed the mergedata-contexts branch 2 times, most recently from 16e95cf to b07e091 Compare December 5, 2019 17:56
@codecov
Copy link

codecov bot commented Dec 5, 2019

Codecov Report

Merging #4248 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4248      +/-   ##
==========================================
+ Coverage   86.05%   86.05%   +<.01%     
==========================================
  Files         394      394              
  Lines       70227    70260      +33     
==========================================
+ Hits        60432    60464      +32     
- Misses       9795     9796       +1

@janezd janezd changed the title Merge Data: Implement context settings [ENH] Merge Data: Implement context settings Dec 5, 2019
@janezd janezd force-pushed the mergedata-contexts branch 2 times, most recently from d5b3c20 to 7062eec Compare December 5, 2019 22:18
@ajdapretnar
Copy link
Contributor

I have tried several combinations of merging and they work as expected. This seems really nicely done.

@ajdapretnar ajdapretnar merged commit 9cf4905 into biolab:master Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge data remember Row matching
2 participants