[FIX] File: Construct unique column names. #4420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4420 +/- ##
=========================================
Coverage ? 87.46%
=========================================
Files ? 405
Lines ? 74132
Branches ? 0
=========================================
Hits ? 64841
Misses ? 9291
Partials ? 0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #4381
Description of changes
File readers constructing a data table now rely on
get_unique_names_duplicatesfromdata.utilinstead of using their own similar logic.Fixed
get_unique_names_duplicatesfor cases where appending an index collides with an exiting name (['x', 'x', 'x (2)']now returns['x (1)', 'x (3)', 'x (2)'].Includes