-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Edit Domain: Option to merge less frequent values #4477
Conversation
26eafac
to
776b432
Compare
Codecov Report
@@ Coverage Diff @@
## master #4477 +/- ##
==========================================
+ Coverage 83.16% 83.45% +0.28%
==========================================
Files 268 276 +8
Lines 53990 55228 +1238
==========================================
+ Hits 44903 46091 +1188
- Misses 9087 9137 +50 |
6046713
to
fde238d
Compare
0726c24
to
ec4b444
Compare
2545ae9
to
0a19883
Compare
After you select one of the merge options, set its parameter, apply the transformation and then see the result you might want to change the parameter. It is kind of annoying that opening the merge dialog again resets everything (it would be nicer to see what was selected previously and allow a minor correction). |
Also, don't forget to put an [ENH] tag in the PR title (for the changelog). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be merged as is, but I have a list of small comments. Feel free to reject any or even all.
I also thought about this. Then I considered print dialogs, which usually do not remember page intervals, for instance. But I agree with @lanzagar - if it's not too complicated to include this as a setting, please do. |
cbaaac9
to
fb7f0fa
Compare
fb7f0fa
to
86db948
Compare
Now parameters are saved as a Context variable. The solution does not look nice, but I did not see any better option. If it looks too ugly we can remove it. |
86db948
to
60600f3
Compare
60600f3
to
b5f546a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the extra sign in a docstring, the rest seems ok to me.
Issue
Fixes #4436
Description of changes
Added an option to merge less frequent values:
The current implementation of merging selected values moved in a new dialogue.
Includes