[ENH] OWOutliers: Data info displayed in the status bar #4547
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4547 +/- ##
==========================================
+ Coverage 83.37% 83.53% +0.16%
==========================================
Files 279 276 -3
Lines 55779 55303 -476
==========================================
- Hits 46507 46199 -308
+ Misses 9272 9104 -168 |
aturanjanin
force-pushed
the
owoutliers
branch
3 times, most recently
from
5bd2e85
to
fda42c1
Compare
aturanjanin
changed the title
aturanjanin
force-pushed
the
owoutliers
branch
2 times, most recently
from
676d7f5
to
6331696
Compare
aturanjanin
changed the title
| @@ -130,13 +131,17 @@ def test_nans(self): | |||
|
|
|||
| def test_in_out_summary(self): | |||
| info = self.widget.info | |||
| data = self.iris | |||
| input_sum = self.widget.info.set_input_summary = Mock() | |||
| output_sum = self.widget.info.set_output_summary = Mock() | |||
There was a problem hiding this comment.
There is not much point in self.assertEqual(info._StateInfo__input_summary.brief, "") lines, since self.widget.info.set_input_summary was mocked.
There was a problem hiding this comment.
The same goes for the code some lines below.
info._StateInfo__input_summary.brief could never have been changed, since mocked, so there is no point of testing it.
You could leave the test as it was, just add the lines to test the detail:
self.assertEqual(info._StateInfo__input_summary.detail, detail)
| @@ -130,13 +131,17 @@ def test_nans(self): | |||
|
|
|||
| def test_in_out_summary(self): | |||
| info = self.widget.info | |||
| data = self.iris | |||
| input_sum = self.widget.info.set_input_summary = Mock() | |||
| output_sum = self.widget.info.set_output_summary = Mock() | |||
There was a problem hiding this comment.
The same goes for the code some lines below.
info._StateInfo__input_summary.brief could never have been changed, since mocked, so there is no point of testing it.
You could leave the test as it was, just add the lines to test the detail:
self.assertEqual(info._StateInfo__input_summary.detail, detail)
aturanjanin
force-pushed
the
owoutliers
branch
3 times, most recently
from
db40e92
to
4fb67e1
Compare
Description of changes
Modification of the status bar data info display.
Includes