Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Select Rows: Allow partial context matches #4740

Merged
merged 1 commit into from
May 8, 2020

Conversation

janezd
Copy link
Contributor

@janezd janezd commented May 5, 2020

Issue
Description of changes

Allow partial matches (but request matching at least one attribute) and remove non-matching conditions.

In case of multiple matches, take the match with the most matching variables.

Includes
  • Code changes
  • Tests

@codecov
Copy link

codecov bot commented May 5, 2020

Codecov Report

Merging #4740 into master will increase coverage by 0.00%.
The diff coverage is 86.66%.

@@           Coverage Diff           @@
##           master    #4740   +/-   ##
=======================================
  Coverage   83.69%   83.70%           
=======================================
  Files         275      275           
  Lines       55620    55629    +9     
=======================================
+ Hits        46551    46562   +11     
+ Misses       9069     9067    -2     

@janezd
Copy link
Contributor Author

janezd commented May 5, 2020

This PR won't have >= 95 % diff coverage because conditions is the only context setting at the moment, so if setting.name != "conditions" can never be true, but it must remain there for the case we add some it in the future.

@lanzagar lanzagar merged commit e9f54cc into biolab:master May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants