Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] SqlTable use empty string instead of None for StringVariable #5120

Merged
merged 4 commits into from
Dec 18, 2020

Conversation

PrimozGodec
Copy link
Contributor

@PrimozGodec PrimozGodec commented Dec 15, 2020

Issue
  • SQL table places None where missing value for StringVariable. It should use '' (empty string) instead. It breaks merge data widget with does not expect None in the String variable.
  • SQL table tests do not cleanup the database after testing.
Description of changes
  • Removing SqlRowInstance and using Instance instead since it seems that Instance does the same in the __init__ that SqlRowInstance used to do. It also correctly replaces None with the '' (empty string). Hope I didn't missee anything.
  • Remove the database tables after testing
Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Dec 15, 2020

Codecov Report

Merging #5120 (6804210) into master (ef789ee) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5120      +/-   ##
==========================================
- Coverage   84.77%   84.77%   -0.01%     
==========================================
  Files         286      286              
  Lines       60084    60078       -6     
==========================================
- Hits        50938    50929       -9     
- Misses       9146     9149       +3     

@PrimozGodec PrimozGodec changed the title Fix SqlTable to use empty string instead of None for StringVariable [FIX] SqlTable use empty string instead of None for StringVariable Dec 15, 2020
@lanzagar lanzagar merged commit bc30f75 into biolab:master Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants