Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Projections: Allow transparent subset #5141

Merged
merged 1 commit into from
Jan 21, 2021

Conversation

janezd
Copy link
Contributor

@janezd janezd commented Dec 18, 2020

Issue

Resolves #5109.

Description of changes
  • No longer disable opacity in presence of data subset
  • If opacity is low and subset is present, inform the user (s)he should increase opacity if (s)he can't see the subset
Includes
  • Code changes
  • Tests

@janezd janezd changed the title Projections: Allow transparent subset [ENH] Projections: Allow transparent subset Dec 18, 2020
@janezd janezd self-assigned this Jan 8, 2021
@janezd janezd force-pushed the projection-allow-transparent-subset branch from de79816 to e5e3366 Compare January 8, 2021 11:13
@codecov
Copy link

codecov bot commented Jan 8, 2021

Codecov Report

Merging #5141 (e5e3366) into master (b7d0da8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #5141   +/-   ##
=======================================
  Coverage   84.78%   84.78%           
=======================================
  Files         286      286           
  Lines       60098    60124   +26     
=======================================
+ Hits        50954    50977   +23     
- Misses       9144     9147    +3     

@janezd janezd assigned janezd and BlazZupan and unassigned janezd Jan 8, 2021
@BlazZupan
Copy link
Contributor

Works fine and the warning comes handy.

@BlazZupan BlazZupan merged commit 3d6b923 into biolab:master Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Geo Map disables Opacity when data subset signal present
2 participants