[FIX] Distribution: vectorize variance, speeds up normalization #5230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5230 +/- ##
==========================================
+ Coverage 85.17% 85.19% +0.01%
==========================================
Files 300 300
Lines 60970 60970
==========================================
+ Hits 51934 51942 +8
+ Misses 9036 9028 -8 |
This makes normalization much faster.
markotoplak
force-pushed
the
norm-faster
branch
from
805ce6e
to
dba28fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Variance used python loops, making it very inefficient. This change alone speeds-up normalization for test-case from #5219 by 10x. Issue #5219 will remain open because it is still possible to substantially improve normalization.
Includes