[ENH] Violin Plot: New widget #5252
Conversation
VesnaT
force-pushed
the
violinplot
branch
2 times, most recently
from
67c4fa8
to
171bb87
Compare
Codecov Report
@@ Coverage Diff @@
## master #5252 +/- ##
==========================================
+ Coverage 85.19% 85.33% +0.13%
==========================================
Files 300 301 +1
Lines 60977 61773 +796
==========================================
+ Hits 51950 52714 +764
- Misses 9027 9059 +32 |
VesnaT
force-pushed
the
violinplot
branch
4 times, most recently
from
581073d
to
e4f6104
Compare
|
|
VesnaT
force-pushed
the
violinplot
branch
2 times, most recently
from
91ebfc2
to
cedc3fe
Compare
|
Icon is available once rebased. :) |
| sorted_model.setSourceModel(self._value_var_model) | ||
| sorted_model.sort(0) | ||
|
|
||
| view = self._value_var_view = ListViewSearch() |
There was a problem hiding this comment.
These ListViewSerach boxes need a greater minimum height. Now, these selectors are useless if the widget is small enough that the controlArea scrollbar is shown.
Why are they so small?
|
Nice widget! When the feature we use for subgrouping that is originally numerical is discretized, the axis labels overlap and become unreadable. Here I used the housing data set and discretized CRIM.
|
|
Labels overlap when subgrouping variable has enough values, say, over five. I am using adult data set here. This is perhaps generic problem for most similar widgets. Labels should be displayed vertically in such cases, and I am not sure if this should be corrected in this widget alone.
|
|
If the variable has only one single value, the plot remains empty. That is, the box plot is too tiny to be displayed (probably the height of the box plot is 0). In such cases, strip plot would display the points, and rug plot would be empty as well (no lines displayed). Should we set the minimum height of the box plot? Why is there no rug plot (a single line) in such case? I am using adult data in this example.
|
|
A possible solution for overlapping labels. Saves space compared to verticals and is probably easier to read.
|
|
How about something like that?
Should not be difficult to apply since already implemented. |
Issue
Fixes #5215
Includes