Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Test and Score: Fix stratification warnings #5281

Merged
merged 1 commit into from
Feb 19, 2021

Conversation

janezd
Copy link
Contributor

@janezd janezd commented Feb 18, 2021

Issue

Fixes #5028.

Besides, the stratification flag was actually ignored; cross-validation was always stratified.

Description of changes
  • Warn for not stratifying when classes are discrete and the least populated has less than k instances.
  • Inform when the flag is on, but data is about regression.
Includes
  • Code changes
  • Tests

@janezd janezd force-pushed the testandscore-warn-not-stratified branch from 9da491d to ee010e7 Compare February 18, 2021 19:36
@codecov
Copy link

codecov bot commented Feb 18, 2021

Codecov Report

Merging #5281 (993d59c) into master (50345c2) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5281      +/-   ##
==========================================
+ Coverage   85.19%   85.21%   +0.01%     
==========================================
  Files         300      300              
  Lines       60977    60992      +15     
==========================================
+ Hits        51950    51973      +23     
+ Misses       9027     9019       -8     

@janezd janezd force-pushed the testandscore-warn-not-stratified branch from ee010e7 to 993d59c Compare February 18, 2021 21:30
@ajdapretnar ajdapretnar merged commit 6ed29b1 into biolab:master Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test & Score: bring back k < class members Warning
2 participants