Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #5580, where the calculation of the bins for automatic … #5667

Merged
merged 1 commit into from
Oct 23, 2021

Conversation

HannesLum
Copy link
Contributor

…coloring in Scatter Plot may lead to an integer overflow.

Issue

Resolves #5580

Description of changes

Minor change in Orange/widgets/utils/colorpalettes.py at line 409, of the calculation of mean values, in order to prevent an integer overflow from happening.

Includes
  • Code changes
  • Tests
  • Documentation

…matic coloring in Scatter Plot may lead to an integer overflow.
@codecov
Copy link

codecov bot commented Oct 23, 2021

Codecov Report

Merging #5667 (573d8e1) into master (3c235f0) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5667      +/-   ##
==========================================
- Coverage   86.02%   86.01%   -0.02%     
==========================================
  Files         315      315              
  Lines       65948    65948              
==========================================
- Hits        56732    56725       -7     
- Misses       9216     9223       +7     

@thocevar thocevar merged commit e350d5e into biolab:master Oct 23, 2021
markotoplak pushed a commit to markotoplak/orange3 that referenced this pull request Oct 27, 2021
Fix for issue biolab#5580: overflow in bin calculations for time variables.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error with coloring in Visualize/Scatter Plot when using certain set of data.
2 participants