Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] owcsvimport: Reduce sample size #5960

Merged
merged 1 commit into from
May 6, 2022

Conversation

ales-erjavec
Copy link
Contributor

Issue

Opening some files for the first time can take a surprising amount of time before the detailed import options dialog is displayed.

Example file

dataset.csv

The time is spent in csv.Sniffer.sniff

Description of changes

Reduce sample text size from 1MiB to 4KiB

Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #5960 (0e4b994) into master (5658a6f) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #5960   +/-   ##
=======================================
  Coverage   86.31%   86.31%           
=======================================
  Files         315      315           
  Lines       67068    67068           
=======================================
  Hits        57891    57891           
  Misses       9177     9177           

@janezd janezd self-assigned this May 6, 2022
@janezd janezd merged commit 4a93f6c into biolab:master May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants