[FIX] Table - copy attributes when creating table from table #6189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
PrimozGodec
force-pushed
the
table-copy-attributes
branch
2 times, most recently
from
2137668
to
89cd5b1
Compare
PrimozGodec
force-pushed
the
table-copy-attributes
branch
from
89cd5b1
to
b58244b
Compare
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When the table is created from the table, the attributes dict is not copied, which means that changing attributes in the new table also change attributes in the original table.
Description of changes
Deep copy the attributes dictionary when creating a table with
from_tableorfrom_table_rows. As discussed at the meeting, the copy should be a deep copy also to copy the structures inside the dictionary, such as lists or sets.Includes