-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Rank - make sorting setting PyQt6 compatible #6301
Conversation
@markotoplak I cannot reproduce the issue you reported, but I fixed it to be PyQt6 compatible now. Can you try if the issue is solved for you? |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6301 +/- ##
==========================================
- Coverage 87.48% 87.47% -0.01%
==========================================
Files 316 316
Lines 68043 68085 +42
==========================================
+ Hits 59526 59556 +30
- Misses 8517 8529 +12 |
4ea13d5
to
9851139
Compare
This PR does not fix the problem. I still get
after opening Orange with PyQt6 onto settings saved in Orange and PyQt5. But it did fix the opposite problem (saving settings with PyQt6 and opening with PyQt5). Then I checked what the created defaults file is like. I see I tried making this int even more "inty" by doing |
73a6da4
to
6f65964
Compare
6f65964
to
c5563f5
Compare
@PrimozGodec, thanks! I added a commit that just bumps the |
I agree with this change. |
Issue
Probably fixes #6229
Description of changes
Store the sorting setting as an integer and transform it to Qt.SortOrder when passed to model/wiev
Includes