[FIX] owtable: Remove multiple connections to 'selectionFinished' #6404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to bad refactoring multiple connections to selectedFinished signal were established leading to multiple calls to commit.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6404 +/- ##
=======================================
Coverage 87.59% 87.60%
=======================================
Files 321 321
Lines 68947 68947
=======================================
+ Hits 60397 60398 +1
+ Misses 8550 8549 -1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Due to bad refactoring multiple connections to selectedFinished signal were established (on each input change) leading to multiple calls to commit.
Description of changes
Remove multiple connections to 'selectionFinished'
Includes