Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] SOM: Store selection Settings in list instead of np.ndarray #6423

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

PrimozGodec
Copy link
Contributor

Issue

The orange widget base does not support settings with type np.ndarrray

Traceback (most recent call last):
  File "../orange-canvas-core/orangecanvas/application/canvasmain.py", line 1612, in save_swp
    if not document.isModifiedStrict() and undoStack.isClean():
  File "../orange-canvas-core/orangecanvas/document/schemeedit.py", line 664, in isModifiedStrict
    node_properties(self.__scheme)
  File "../orange-canvas-core/orangecanvas/document/schemeedit.py", line 2538, in node_properties
    scheme.sync_node_properties()
  File "../orange-widget-base/orangewidget/workflow/widgetsscheme.py", line 99, in sync_node_properties
    if settings != node.properties:
ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
Description of changes

Store SOM's settings in a list instead.

Includes
  • Code changes
  • Tests
  • Documentation

@PrimozGodec PrimozGodec changed the title SOM - Store selection Settings in list instead of np.ndarray [FIX] SOM - Store selection Settings in list instead of np.ndarray Apr 24, 2023
@PrimozGodec PrimozGodec marked this pull request as ready for review April 24, 2023 09:55
@lanzagar lanzagar changed the title [FIX] SOM - Store selection Settings in list instead of np.ndarray [FIX] SOM: Store selection Settings in list instead of np.ndarray Apr 24, 2023
@lanzagar lanzagar merged commit 3cc58b4 into biolab:master Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants