Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradient boosting - Adapt tests to version xgboost=2; move xgboost/catboost to regular requirements #6570

Merged
merged 2 commits into from
Sep 15, 2023

Conversation

PrimozGodec
Copy link
Contributor

@PrimozGodec PrimozGodec commented Sep 12, 2023

Issue

Xgboost released version 2.0.0, which changes some internal interfaces and breaks our tests.

Description of changes

Adapt tests to 2.0.0.

Also, now Xgboost packs Libomp in wheels for Macos (I think it was a primary reason for keeping Xgbosot and Catboost optional dependency). I suggest including both as a mandatory dependency. They are packed in Installers and part of a conda-forge package already/anyway.

Includes
  • Code changes
  • Tests
  • Documentation

@PrimozGodec PrimozGodec force-pushed the fix-xgboost branch 2 times, most recently from fad3f02 to 4e7571c Compare September 12, 2023 09:18
@PrimozGodec PrimozGodec added the needs discussion Core developers need to discuss the issue label Sep 12, 2023
@markotoplak
Copy link
Member

markotoplak commented Sep 14, 2023

Does new xgboost only break tests or also widgets? If the latter, we will perhaps need 3.36.1.

@markotoplak
Copy link
Member

Oh, I now see there were just the tests.

@markotoplak markotoplak reopened this Sep 14, 2023
@PrimozGodec
Copy link
Contributor Author

PrimozGodec commented Sep 14, 2023

@markotoplak, no need for 3.36.1. It breaks only tests.

I decided to fix it to xgboost>=2 since it doesn't hurt. If we don't want to do this, we will need to write two versions of tests.

@markotoplak
Copy link
Member

Can you also update meta.yaml?

Conda-forge only has xgboost 1.7 for now, but that is likely not much of a problem. Anything that relies on building Orange though conda build would fail until they release 2.0. Maybe that is not much of a problem.

@PrimozGodec PrimozGodec force-pushed the fix-xgboost branch 2 times, most recently from df1ec82 to d6a6b95 Compare September 15, 2023 08:16
@PrimozGodec
Copy link
Contributor Author

I updated meta.yaml. I didn't fix the version there. I think it should work for now.

@PrimozGodec PrimozGodec force-pushed the fix-xgboost branch 2 times, most recently from 110136a to c5a8ff4 Compare September 15, 2023 12:16
@PrimozGodec PrimozGodec changed the title Gradient boosting - Adapt tests to version xgboost=2.0.0 Gradient boosting - Adapt tests to version xgboost=2; move xgboost/catboost to regular requirements Sep 15, 2023
@markotoplak markotoplak removed the needs discussion Core developers need to discuss the issue label Sep 15, 2023
@markotoplak markotoplak merged commit 3dd6d9c into biolab:master Sep 15, 2023
15 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants