Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Predictions: Output errors #6577

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Conversation

VesnaT
Copy link
Contributor

@VesnaT VesnaT commented Sep 15, 2023

Issue

Fixes #6572

Description of changes

Attach prediction errors to output when the errors are shown in the table.

Includes
  • Code changes
  • Tests
  • Documentation

@markotoplak
Copy link
Member

/rebase

@markotoplak markotoplak changed the title Prediction: Output error [ENH] Predictions: Output errors Sep 18, 2023
@markotoplak
Copy link
Member

@janezd, this PR seem like a cool addition. Initially I was against (should we really output things that people can easily compute in Formula?), but I changed my mind in discussion with Vesna. The single error column per predictor seems like a sensible idea (and users can also select error types in the widget, which was the thing that convinced me).

Maybe this could also go into 3.36.1, if you perhaps have to review it?

@janezd janezd self-assigned this Sep 22, 2023
@janezd janezd merged commit 88baad6 into biolab:master Sep 22, 2023
14 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Predictions: include error in 'Predictions' output
3 participants