fix: void error on type of a function declaration (#309)

Co-authored-by: Victorien Elvinger <victorien@elvinger.fr>
biomejs · Sep 17, 2023 · 37e91e7 · 37e91e7
1 parent 214dd31
commit 37e91e7
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -27,6 +27,10 @@ Read our [guidelines for writing a good changelog entry](https://github.com/biom
 
 - Add [noMisleadingInstantiator](https://biomejs.dev/linter/rules/no-mileading-instantiator) rule. The rule reports the misleading use of the `new` and `constructor` methods. Contributed by @unvalley
 
+#### Bug fixes
+
+- Fix [#294](https://github.com/biomejs/biome/issues/294). [noConfusingVoidType](https://biomejs.dev/linter/rules/no-confusing-void-type/) no longer reports false positives for return types. Contributed by @b4s36t4
+
 ### Parser
 ### VSCode
 

diff --git a/crates/biome_js_analyze/src/analyzers/nursery/no_confusing_void_type.rs b/crates/biome_js_analyze/src/analyzers/nursery/no_confusing_void_type.rs
@@ -114,6 +114,7 @@ fn node_in(node: &SyntaxNode<Language>) -> Option<VoidTypeIn> {
             JsSyntaxKind::TS_THIS_PARAMETER
             | JsSyntaxKind::TS_RETURN_TYPE_ANNOTATION
             | JsSyntaxKind::TS_TYPE_PARAMETER
+            | JsSyntaxKind::TS_FUNCTION_TYPE
             | JsSyntaxKind::TS_TYPE_ARGUMENT_LIST => {
                 return None;
             }

diff --git a/crates/biome_js_analyze/tests/specs/nursery/noConfusingVoidType/valid.ts b/crates/biome_js_analyze/tests/specs/nursery/noConfusingVoidType/valid.ts
@@ -5,3 +5,5 @@ logAndReturn<void>(undefined);
 
 let voidPromise: Promise<void> = new Promise<void>(() => { });
 let voidMap: Map<string, void> = new Map<string, void>();
+
+type FallbackHandler = (error?: Error) => void;
diff --git a/crates/biome_js_analyze/tests/specs/nursery/noConfusingVoidType/valid.ts.snap b/crates/biome_js_analyze/tests/specs/nursery/noConfusingVoidType/valid.ts.snap
@@ -1,6 +1,5 @@
 ---
 source: crates/biome_js_analyze/tests/spec_tests.rs
-assertion_line: 80
 expression: valid.ts
 ---
 # Input
@@ -13,6 +12,7 @@ logAndReturn<void>(undefined);
 let voidPromise: Promise<void> = new Promise<void>(() => { });
 let voidMap: Map<string, void> = new Map<string, void>();
 
+type FallbackHandler = (error?: Error) => void;
 ```
 
 
diff --git a/website/src/content/docs/internals/changelog.mdx b/website/src/content/docs/internals/changelog.mdx
@@ -33,6 +33,10 @@ Read our [guidelines for writing a good changelog entry](https://github.com/biom
 
 - Add [noMisleadingInstantiator](https://biomejs.dev/linter/rules/no-mileading-instantiator) rule. The rule reports the misleading use of the `new` and `constructor` methods. Contributed by @unvalley
 
+#### Bug fixes
+
+- Fix [#294](https://github.com/biomejs/biome/issues/294). [noConfusingVoidType](https://biomejs.dev/linter/rules/no-confusing-void-type/) no longer reports false positives for return types. Contributed by @b4s36t4
+
 ### Parser
 ### VSCode
Original file line number	Diff line number	Diff line change
Expand Up		@@ -5,3 +5,5 @@ logAndReturn<void>(undefined);

		let voidPromise: Promise<void> = new Promise<void>(() => { });
		let voidMap: Map<string, void> = new Map<string, void>();

		type FallbackHandler = (error?: Error) => void;