fix(analyzer): False positive in rule noUndeclaredVariables #243

[denbezrukov]

Summary

Fix #243

We don't need to check the correct position of infer types in semantics because our parser raises an error if they are in an invalid position. #308

Thank to @strager for the explanation.

Test Plan

cargo test

[github-actions]

Parser conformance results on

js/262

Test result	main count	This PR count	Difference
Total	48863	48863	0
Passed	47808	47808	0
Failed	1055	1055	0
Panics	0	0	0
Coverage	97.84%	97.84%	0.00%

jsx/babel

Test result	main count	This PR count	Difference
Total	40	40	0
Passed	37	37	0
Failed	3	3	0
Panics	0	0	0
Coverage	92.50%	92.50%	0.00%

symbols/microsoft

Test result	main count	This PR count	Difference
Total	6212	6212	0
Passed	1764	1767	✅ ⏫ +3
Failed	4448	4445	✅ ⏬ -3
Panics	0	0	0
Coverage	28.40%	28.44%	+0.05%

🎉 Fixed (3):

conditionalTypeGenericInSignatureTypeParameterConstraint.symbols
inferTInParentheses.symbols
typeAliasFunctionTypeSharedSymbol.symbols

ts/babel

Test result	main count	This PR count	Difference
Total	639	639	0
Passed	571	571	0
Failed	68	68	0
Panics	0	0	0
Coverage	89.36%	89.36%	0.00%

ts/microsoft

Test result	main count	This PR count	Difference
Total	17224	17224	0
Passed	13123	13123	0
Failed	4101	4101	0
Panics	0	0	0
Coverage	76.19%	76.19%	0.00%

[ematipico]

!bench_analyzer

I want to check if the workflow is fixed

[github-actions]

Analyzer Benchmark Results

group                     main                                   pr
-----                     ----                                   --
analyzer/css.js           1.00      4.4±0.00ms     2.7 MB/sec    1.01      4.4±0.02ms     2.7 MB/sec
analyzer/index.js         1.00      9.0±0.03ms     3.4 MB/sec    1.01      9.1±0.04ms     3.3 MB/sec
analyzer/lint.ts          1.00      6.8±0.04ms     6.1 MB/sec    1.02      6.9±0.01ms     6.0 MB/sec
analyzer/parser.ts        1.00     13.3±0.10ms     3.7 MB/sec    1.02     13.6±0.03ms     3.6 MB/sec
analyzer/router.ts        1.00      4.3±0.00ms     5.4 MB/sec    1.01      4.4±0.00ms     5.4 MB/sec
analyzer/statement.ts     1.00     12.5±0.06ms     2.8 MB/sec    1.01     12.7±0.02ms     2.8 MB/sec
analyzer/typescript.ts    1.00     19.7±0.15ms     2.8 MB/sec    1.02     20.0±0.08ms     2.7 MB/sec

[denbezrukov]

!bench_analyzer

I want to check if the workflow is fixed

What do you think if there is a better way to check if a type is inside a conditional branch?
We have to go to a parent and compare a node with a true type for every TsNode.
I'm wondering if we can somehow know that the next node is a true type.

If its a performance regression we can try to narrow node kinds, because not every type node needs its own scope in a true branch. But it makes code more complex.

[ematipico]

I think the implementation is fine as is!

Sorry if I used your PR to trigger the benchmark. The workflows were broken for a long time, and I wanted to check if they were finally fixed.

[github-actions]

Analyzer Benchmark Results

group                     main                                   pr
-----                     ----                                   --
analyzer/css.js           1.00      4.4±0.00ms     2.7 MB/sec    1.01      4.4±0.01ms     2.7 MB/sec
analyzer/index.js         1.00      9.0±0.02ms     3.4 MB/sec    1.01      9.1±0.01ms     3.4 MB/sec
analyzer/lint.ts          1.00      6.7±0.01ms     6.2 MB/sec    1.02      6.9±0.03ms     6.0 MB/sec
analyzer/parser.ts        1.00     13.2±0.05ms     3.7 MB/sec    1.02     13.5±0.12ms     3.6 MB/sec
analyzer/router.ts        1.00      4.3±0.00ms     5.5 MB/sec    1.02      4.4±0.00ms     5.4 MB/sec
analyzer/statement.ts     1.00     12.4±0.03ms     2.9 MB/sec    1.01     12.6±0.14ms     2.8 MB/sec
analyzer/typescript.ts    1.00     19.5±0.03ms     2.8 MB/sec    1.02     19.8±0.09ms     2.7 MB/sec