fix: reduce accepted values for options #4271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Formatter
unvalley
approved these changes
Oct 13, 2024
unvalley
approved these changes
Oct 13, 2024
CodSpeed Performance ReportMerging #4271 will degrade performances by 7.14%Comparing Summary
Benchmarks breakdown
|
ematipico
added a commit
that referenced
this pull request
Oct 18, 2024
ematipico
added a commit
that referenced
this pull request
Oct 18, 2024
Conaclos
pushed a commit
that referenced
this pull request
Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3619
Test Plan
We don't have tests for these cases, however I felt having a changeset was more appropriate.