Skip to content

Commit

Permalink
fix(ci): fix path to lighthouse-config
Browse files Browse the repository at this point in the history
  • Loading branch information
bionicles committed Jan 21, 2020
1 parent 231f813 commit 9822a20
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 21 deletions.
6 changes: 2 additions & 4 deletions .github/workflows/master.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,8 @@ jobs:
if: success()
uses: treosh/lighthouse-ci-action@v2
with:
configPath: ".lighthouseci/lighthouserc.json"
urls: |
http://localhost:3000
http://localhost:3000/blog
configPath: ".lighthouseci/lighthouse-config.json"
urls: http://localhost:3000
- name: Release
if: success()
env:
Expand Down
16 changes: 16 additions & 0 deletions .lighthouseci/lighthouse-config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
module.exports = {
extends: "lighthouse:default",
settings: {
scores: {
performance: 90,
accessibility: 90,
"best-practices": 90,
seo: 80
},
onlyCategories: ["performance", "accessibility", "best-practices", "seo"],
skipAudits: [
"byte-efficiency/uses-responsive-images",
"byte-efficiency/uses-webp-images"
]
}
};
16 changes: 0 additions & 16 deletions .lighthouseci/lighthouserc.json

This file was deleted.

2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ prebuild.unit:
cd www && yarn test

lighthouse:
lighthouse http://localhost:3000 --view --config-path=.lighthouseci/lighthouserc.json --output-path=.lighthouseci/lighthouse-results.html
lighthouse http://localhost:3000 --view --config-path=.lighthouseci/lighthouse-config.json --output-path=.lighthouseci/lighthouse-results.html

e2e:
docker run --net=host -v ${home}/www/__tests__/e2e:/tests -e TEST_URL=http://localhost:3000 codeception/codeceptjs codeceptjs run --steps --debug --verbose
Expand Down

0 comments on commit 9822a20

Please sign in to comment.